You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the pubring files are read-only (for many reasons this can be the case, for example some source control systems like Perforce set all repo contents to read-only until they are "checked out"), git-secret does not edit them.
Therefore, editing the keyring with git secret tell ... should fail in this case and display an error to the user. Alternatively, it can ask something like "do you want to overwrite read-only file?".
However, currently, the command silently quits, and with no error message the user doesn't know that anything went wrong.
What are the steps to reproduce this issue?
Set pubring.kbx and pubring.kbx~ files to read-only.
Attempt to git secret tell to a new user.
What happens?
Nothing is displayed, pubring files are left untouched.
When the pubring files are read-only (for many reasons this can be the case, for example some source control systems like Perforce set all repo contents to read-only until they are "checked out"), git-secret does not edit them.
Therefore, editing the keyring with
git secret tell ...
should fail in this case and display an error to the user. Alternatively, it can ask something like "do you want to overwrite read-only file?".However, currently, the command silently quits, and with no error message the user doesn't know that anything went wrong.
What are the steps to reproduce this issue?
git secret tell
to a new user.What happens?
Nothing is displayed, pubring files are left untouched.
What were you expecting to happen?
An error message or overwrite dialog.
What versions of software are you using?
Operating system: (
uname -a
) 5.10.16.3-microsoft-standard-WSL2 #1 SMP Fri Apr 2 22:23:49 UTC 2021 x86_64 x86_64 x86_64 GNU/Linuxgit-secret
path: (which git-secret
) /usr/bin/git-secretgit-secret
version: (git secret --version
) 0.5.0git
version: (git --version
) 2.25.1Shell type and version: (
$SHELL --version
) GNU bash, version 5.0.17(1)-release (x86_64-pc-linux-gnu)gpg
version: (gpg --version
) gpg (GnuPG) 2.2.19 libgcrypt 1.8.5The text was updated successfully, but these errors were encountered: