This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
[MRG + 1] Rename the kwarg table_area to table_areas
#171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`table_areas` sounds more apt since it is a list and there can be multiple table areas on a page. Closes #165
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=======================================
Coverage 84.17% 84.17%
=======================================
Files 13 13
Lines 1226 1226
Branches 294 294
=======================================
Hits 1032 1032
Misses 150 150
Partials 44 44
Continue to review full report at Codecov.
|
vinayak-mehta
changed the title
table_area to table_areastable_area to table_areas
vinayak-mehta
changed the title
table_area to table_areastable_area to table_areas
vinayak-mehta
changed the title
table_area to table_areastable_area to table_areas
|
@pqrth Thanks for the contribution! |
kirbs-
pushed a commit
to kirbs-/camelot
that referenced
this pull request
Jul 31, 2020
Change error name and update pdfminer.six version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
table_areassounds more apt since it is a list and there can bemultiple table areas on a page.
Closes #165