[perf] Use strict equality where possible (#77)

Author: billouboq

lib/browser.js

@@ -87,12 +87,12 @@ var Blob = require('blob');
  */
 
 exports.encodePacket = function (packet, supportsBinary, utf8encode, callback) {
-  if ('function' == typeof supportsBinary) {
+  if (typeof supportsBinary === 'function') {
     callback = supportsBinary;
     supportsBinary = false;
   }
 
-  if ('function' == typeof utf8encode) {
+  if (typeof utf8encode === 'function') {
     callback = utf8encode;
     utf8encode = null;
   }
@@ -226,8 +226,8 @@ exports.decodePacket = function (data, binaryType, utf8decode) {
     return err;
   }
   // String data
-  if (typeof data == 'string') {
-    if (data.charAt(0) == 'b') {
+  if (typeof data === 'string') {
+    if (data.charAt(0) === 'b') {
       return exports.decodeBase64Packet(data.substr(1), binaryType);
     }
 
@@ -307,7 +307,7 @@ exports.decodeBase64Packet = function(msg, binaryType) {
  */
 
 exports.encodePayload = function (packets, supportsBinary, callback) {
-  if (typeof supportsBinary == 'function') {
+  if (typeof supportsBinary === 'function') {
     callback = supportsBinary;
     supportsBinary = null;
   }
@@ -370,7 +370,7 @@ function map(ary, each, done) {
  */
 
 exports.decodePayload = function (data, binaryType, callback) {
-  if (typeof data != 'string') {
+  if (typeof data !== 'string') {
     return exports.decodePayloadAsBinary(data, binaryType, callback);
   }
 
@@ -380,7 +380,7 @@ exports.decodePayload = function (data, binaryType, callback) {
   }
 
   var packet;
-  if (data == '') {
+  if (data === '') {
     // parser error - ignoring payload
     return callback(err, 0, 1);
   }
@@ -390,12 +390,12 @@ exports.decodePayload = function (data, binaryType, callback) {
   for (var i = 0, l = data.length; i < l; i++) {
     var chr = data.charAt(i);
 
-    if (':' != chr) {
+    if (chr !== ':') {
       length += chr;
       continue;
     }
 
-    if ('' == length || (length != (n = Number(length)))) {
+    if (length === '' || (length != (n = Number(length)))) {
       // parser error - ignoring payload
       return callback(err, 0, 1);
     }
@@ -410,7 +410,7 @@ exports.decodePayload = function (data, binaryType, callback) {
     if (msg.length) {
       packet = exports.decodePacket(msg, binaryType, false);
 
-      if (err.type == packet.type && err.data == packet.data) {
+      if (err.type === packet.type && err.data === packet.data) {
         // parser error in individual packet - ignoring payload
         return callback(err, 0, 1);
       }
@@ -424,7 +424,7 @@ exports.decodePayload = function (data, binaryType, callback) {
     length = '';
   }
 
-  if (length != '') {
+  if (length !== '') {
     // parser error - ignoring payload
     return callback(err, 0, 1);
   }
@@ -568,7 +568,7 @@ exports.decodePayloadAsBinary = function (data, binaryType, callback) {
     var msgLength = '';
 
     for (var i = 1; ; i++) {
-      if (tailArray[i] == 255) break;
+      if (tailArray[i] === 255) break;
 
       // 310 = char length of Number.MAX_VALUE
       if (msgLength.length > 310) {

lib/index.js

@@ -50,12 +50,12 @@ var err = { type: 'error', data: 'parser error' };
  */
 
 exports.encodePacket = function (packet, supportsBinary, utf8encode, callback) {
-  if ('function' == typeof supportsBinary) {
+  if (typeof supportsBinary === 'function') {
     callback = supportsBinary;
     supportsBinary = null;
   }
 
-  if ('function' == typeof utf8encode ) {
+  if (typeof utf8encode === 'function') {
     callback = utf8encode;
     utf8encode = null;
   }
@@ -122,8 +122,8 @@ exports.decodePacket = function (data, binaryType, utf8decode) {
     return err;
   }
   // String data
-  if (typeof data == 'string') {
-    if (data.charAt(0) == 'b') {
+  if (typeof data === 'string') {
+    if (data.charAt(0) === 'b') {
       return exports.decodeBase64Packet(data.substr(1), binaryType);
     }
 
@@ -208,7 +208,7 @@ exports.decodeBase64Packet = function(msg, binaryType) {
  */
 
 exports.encodePayload = function (packets, supportsBinary, callback) {
-  if (typeof supportsBinary == 'function') {
+  if (typeof supportsBinary === 'function') {
     callback = supportsBinary;
     supportsBinary = null;
   }
@@ -265,7 +265,7 @@ function map(ary, each, done) {
  */
 
 exports.decodePayload = function (data, binaryType, callback) {
-  if ('string' != typeof data) {
+  if (typeof data !== 'string') {
     return exports.decodePayloadAsBinary(data, binaryType, callback);
   }
 
@@ -275,7 +275,7 @@ exports.decodePayload = function (data, binaryType, callback) {
   }
 
   var packet;
-  if (data == '') {
+  if (data === '') {
     // parser error - ignoring payload
     return callback(err, 0, 1);
   }
@@ -285,12 +285,12 @@ exports.decodePayload = function (data, binaryType, callback) {
   for (var i = 0, l = data.length; i < l; i++) {
     var chr = data.charAt(i);
 
-    if (':' != chr) {
+    if (chr !== ':') {
       length += chr;
       continue;
     }
 
-    if ('' == length || (length != (n = Number(length)))) {
+    if (length === '' || (length != (n = Number(length)))) {
       // parser error - ignoring payload
       return callback(err, 0, 1);
     }
@@ -305,7 +305,7 @@ exports.decodePayload = function (data, binaryType, callback) {
     if (msg.length) {
       packet = exports.decodePacket(msg, binaryType, false);
 
-      if (err.type == packet.type && err.data == packet.data) {
+      if (err.type === packet.type && err.data === packet.data) {
         // parser error in individual packet - ignoring payload
         return callback(err, 0, 1);
       }
@@ -319,7 +319,7 @@ exports.decodePayload = function (data, binaryType, callback) {
     length = '';
   }
 
-  if (length != '') {
+  if (length !== '') {
     // parser error - ignoring payload
     return callback(err, 0, 1);
   }
@@ -447,7 +447,7 @@ exports.decodePayloadAsBinary = function (data, binaryType, callback) {
     var strLen = '';
     var isString = bufferTail[0] === 0;
     for (var i = 1; ; i++) {
-      if (bufferTail[i] == 255)  break;
+      if (bufferTail[i] === 255)  break;
       // 310 = char length of Number.MAX_VALUE
       if (strLen.length > 310) {
         return callback(err, 0, 1);