Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent crash when accessing TextDecoder #684

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

iowaguy
Copy link
Contributor

@iowaguy iowaguy commented Jun 26, 2023

This bug was introduced in [1] and included in release 6.5.0.

[1] 123b68c

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

The TextDecoder object was never imported before being used. This is the cause of #683.

New behaviour

Adding the dependency stops the crash from occuring.

Other information (e.g. related issues)

The TextDecoder object was never imported before being used. This bug was introduced in [1]
and included in release 6.5.0.

[1] 123b68c
@darrachequesne darrachequesne merged commit 6dd2bc4 into socketio:main Jun 27, 2023
@darrachequesne
Copy link
Member

Thanks! Released in version 6.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants