Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket.io 3 #1308

Closed
nuclearace opened this issue Nov 7, 2020 · 8 comments
Closed

socket.io 3 #1308

nuclearace opened this issue Nov 7, 2020 · 8 comments
Assignees

Comments

@nuclearace
Copy link
Member

Need to support the changes in engine and socket.

@nuclearace nuclearace self-assigned this Nov 7, 2020
@nuclearace
Copy link
Member Author

Current timeline for getting this merged is either sometime this week, or next weekend, depending on how testing and other things go.

@nuclearace nuclearace pinned this issue Nov 8, 2020
@davenquinn
Copy link

Is it possible to state prominently in the docs or README that Socket.IO v3 is not supported yet, until the support is merged and integrated into the published version? (and then state prominently the version at which Socket.IO v3 support starts)

Version 3 is now the default for Socket.IO proper, and the docs there do not do a great job of highlighting backwards incompatibilities, so I used it without thought for the server. Then, the way logging is handled by this library did not lead me in the right direction to diagnose the underlying issues. I understand this is an "unfortunate timing" sort of problem, and mostly upstream, but it was quite a nasty time trap for me (someone with little understanding of the transport protocols involved).

In the end, downgrading my server to version 2.3.0 fixed my issues with no other code changes on server or client.

@mohamnexus
Copy link

mohamnexus commented Dec 22, 2020

waiting... we need it, please support third version...

@wangyuanfen
Copy link

waiting... we need it

@RomanGalochkin
Copy link

When the third version will be supported?

1 similar comment
@mouadroaui
Copy link

When the third version will be supported?

@nuclearace
Copy link
Member Author

v16.0.0 is been released.

@nuclearace nuclearace unpinned this issue Feb 1, 2021
@justlaputa
Copy link

hi, I know this is closed and 16.0.0 supports V3

It cost me a lot of time to debug my server code, but finally searched in client side source code, to find that v15.2 does not support V3 server.

there is no clear mention in README, this may cause some confusion, as it is conflicting with the V3 doc:

In order to ease the migration to Socket.IO v3, the v3 server is now able to communicate with v2 clients:

const io = require("socket.io")({
  allowEIO3: true // false by default
});

can we add some explicit mention in v15.x's README? so other people won't be confused. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants