Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Comment for publishOnSpecificResponseChannel #554

Open
eora21 opened this issue Nov 30, 2024 · 0 comments
Open

Incorrect Comment for publishOnSpecificResponseChannel #554

eora21 opened this issue Nov 30, 2024 · 0 comments

Comments

@eora21
Copy link

eora21 commented Nov 30, 2024

The comment is as follows:

Whether to publish a response to the channel specific to the requesting node.

- if true, the response will be published to `${key}-request#${nsp}#${uid}#`
- if false, the response will be published to `${key}-request#${nsp}#`

This option currently defaults to false for backward compatibility, but will set to true in the next major release.

@default false

However, the actual response is not published to ${key}-request#${nsp}#${uid}# or ${key}-request#${nsp}#, but to ${key}-response#${nsp}#${uid}# or ${key}-response#${nsp}#.

Below is the Redis logs that I captured while changing the configuration values to confirm the actual behavior.

if true:

1732954490.574914 [0 172.17.0.1:61308] "publish" "socket.io-response#/#XglaEZ#" ...

if false:

1732954953.329108 [0 172.17.0.1:61186] "publish" "socket.io-response#/#" ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant