-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken changes in ie8 #2952
Comments
I will close it due to socketio/socket.io-client#1063 |
@tormozz48 it should be fixed in 2.x version (related to uglifyJS and Related: socketio/socket.io-client#1042 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello.
As you know socket.io is a dependency of karma test unit framework.
And I come here from some issue with unit-test on my project.
I found a commit
in socket.io package that breaks work in ie8 browser
Here you can see row of code that has broken changes:
You want to:
Current behaviour
IE8 browser does not launch from karma test unit framework
Expected behaviour
IE8 browser should work properly as other browsers
Setup
Other information (e.g. stacktraces, related issues, suggestions how to fix)
My version is that minified code from
socket.io-client
dependency does not properly supported by ie8 browser and it fails.The text was updated successfully, but these errors were encountered: