Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken changes in ie8 #2952

Closed
1 of 2 tasks
tormozz48 opened this issue May 25, 2017 · 2 comments
Closed
1 of 2 tasks

Broken changes in ie8 #2952

tormozz48 opened this issue May 25, 2017 · 2 comments

Comments

@tormozz48
Copy link

Hello.

As you know socket.io is a dependency of karma test unit framework.

And I come here from some issue with unit-test on my project.
I found a commit
in socket.io package that breaks work in ie8 browser

Here you can see row of code that has broken changes:

clientSource = read(require.resolve('socket.io-client/dist/socket.io.min.js'), 'utf-8')

You want to:

  • report a bug
  • request a feature

Current behaviour

IE8 browser does not launch from karma test unit framework

Expected behaviour

IE8 browser should work properly as other browsers

Setup

  • OS: windows
  • browser: ie8
  • socket.io version: 1.7.0 and higher (1.6.0 and lower is working fine)

Other information (e.g. stacktraces, related issues, suggestions how to fix)

My version is that minified code from socket.io-client dependency does not properly supported by ie8 browser and it fails.

@tormozz48
Copy link
Author

I will close it due to socketio/socket.io-client#1063

@darrachequesne
Copy link
Member

@tormozz48 it should be fixed in 2.x version (related to uglifyJS and screw_ie8 option)

Related: socketio/socket.io-client#1042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants