Test for graceful close on shared bound endpoints.

Author: ioquatix

lib/async/io/shared_endpoint.rb

@@ -77,16 +77,9 @@ def bind
 				task = Async::Task.current
 
 				@wrappers.each do |server|
-					server = server.dup
-					
 					task.async do |task|
 						task.annotate "binding to #{server.inspect}"
-						
-						begin
-							yield server, task
-						ensure
-							server.close
-						end
+						yield server, task
 					end
 				end
 			end
@@ -109,9 +102,9 @@ def connect
 				end
 			end
 
-			def accept(backlog = nil, &block)
+			def accept(backlog = nil, **options, &block)
 				bind do |server|
-					server.accept_each(&block)
+					server.accept_each(**options, &block)
 				end
 			end
 

spec/async/io/shared_endpoint_spec.rb

@@ -10,7 +10,7 @@
 	include_context Async::RSpec::Reactor
 
 	describe '#bound' do
-		let(:endpoint) {Async::IO::Endpoint.udp("localhost", 5123, timeout: 10)}
+		let(:endpoint) {Async::IO::Endpoint.tcp("localhost", 5123, timeout: 10)}
 
 		it "can bind to shared endpoint" do
 			bound_endpoint = described_class.bound(endpoint)
@@ -33,6 +33,36 @@
 
 			bound_endpoint.close
 		end
+		
+		it "can close a bound endpoint to terminate accept loop" do
+			bound_endpoint = described_class.bound(endpoint)
+			expect(bound_endpoint.wrappers).to_not be_empty
+			
+			server_task = Async do
+				bound_endpoint.accept do |io|
+					io.close
+				end
+			end
+			
+			connect = proc do
+				endpoint.connect do |io|
+					io.write "Hello World"
+					io.close
+				end
+			end
+			
+			connect.call
+			
+			wrapper = bound_endpoint.wrappers.first
+			expect(wrapper).to be_a Async::IO::Socket
+			
+			bound_endpoint.close
+			expect(wrapper).to be_closed
+			
+			expect do
+				connect.call
+			end.to raise_error(Errno::ECONNRESET)
+		end
 	end
 
 	describe '#connected' do