Suggest windows and aws #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I created a JIRA issue linking to this PR which can be found here: https://tickets.opscode.com/browse/COOK-4216 |
|
Looks good. My only concern was that suggests was added in a relatively recent Chef client release, but it looks like it's been there for almost 3 years. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #92, it seems to me that full fledged dependencies on aws and windows is excessive for pure Linux environments.
As suggested by @carmstrong, this change moves from depends to suggests for both aws and windows.
YMMV, but switching to suggests moved my chef setup from failing to compile (even though I cloned down the aws and windows cookbooks), to a working state where I am able to compile and run successfully.
If this patch is accepted, it should resolve #92 as well.