Fix JDK install on Windows. #131
Conversation
Commit b42c246 introduces quotes around the install path, so that we can safely provide paths with strings. Unfortunately, it seems that this method works only with JREs, not with JDKs. It seems that the recommended way to call the installer (described at http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4966488) is by adding /v"/qn INSTALLDIR=\"path\"" I tested that this change makes it possible to install both a JRE and a JDK.
|
My first thought is that this isn't necessary a bug - this cookbook aims to install the JDK for all platforms, not the JRE package, which will probably break other recipes as well. That said, I am not necessarily opposed to this change, as long as it doesn't break the installation of the JDK. Have you tested this change on Windows by setting Unfortunately I don't think we can run automated tests on Windows like we can on other platforms.. :( |
|
Hi, Just to be clear : in my case, the JDK install was broken, and the JRE install worked. My change fixes it for the JDK install. Yes, I have tested by overridding the |
Fix JDK install on Windows.
|
@cupcicm Good enough for me! Thanks for the patch. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I think that #100 broke the windows install when using a JDK installer.
For example, if I download both a JRE and a JDK here : http://www.oracle.com/technetwork/java/javase/downloads/jdk7-downloads-1880260.html and here http://java.com/en/download/manual.jsp#win
and then run both
.\jdk-7u51-windows-x64.exe /s INSTALLDIR="C:\java"
and
.\jre-7u51-windows-x64.exe /s INSTALLDIR="C:\java"
The second one works, but the first one doesn't. It does when I remove the backward slashes.
The fix seems to be http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4966488
I tested this change with both a JDK and a JRE installer, and both were correctly installed.