-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support to determine whether to set installed java version to defa... #140
Conversation
I created an attribute, node['java']['set_default'](true by default), that is a parameter for the 'alternatives' provider. This was done for the recipes ibm, ibm_tar and openjdk. The recipes oracle and oracle_i386 call the provider java_ark. I pass 'default' to java_ark with the value of 'node['java']['set_default']. The oracle_rpm recipe does not call either provider (alternatives or ark). My changes from before persist. Please let me know if I'm missing something, but I don't see a better way to handle this for the oracle_rpm recipe. |
@@ -28,6 +28,7 @@ | |||
|
|||
java_home = node['java']["java_home"] | |||
arch = node['java']['arch'] | |||
set_default = node['java']['set_default'] |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…of case statement
Recommended changes pushed. Thanks! |
@@ -47,7 +47,8 @@ | |||
end | |||
|
|||
java_ark "jdk-alt" do | |||
url tarball_url | |||
url node['java']['set_default'] |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Fixed, sorry about that. |
added support to determine whether to set installed java version to defa...
👍 |
@cantenesse could you also update README.md to reference the newly-created attribute? |
Will do.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
...ult