Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support to determine whether to set installed java version to defa... #140

Merged
merged 3 commits into from
Feb 24, 2014

Conversation

cantenesse
Copy link
Contributor

...ult

@cantenesse
Copy link
Contributor Author

I created an attribute, node['java']['set_default'](true by default), that is a parameter for the 'alternatives' provider. This was done for the recipes ibm, ibm_tar and openjdk. The recipes oracle and oracle_i386 call the provider java_ark. I pass 'default' to java_ark with the value of 'node['java']['set_default'].

The oracle_rpm recipe does not call either provider (alternatives or ark). My changes from before persist. Please let me know if I'm missing something, but I don't see a better way to handle this for the oracle_rpm recipe.

@@ -28,6 +28,7 @@

java_home = node['java']["java_home"]
arch = node['java']['arch']
set_default = node['java']['set_default']

This comment was marked as outdated.

@cantenesse
Copy link
Contributor Author

Recommended changes pushed. Thanks!

@@ -47,7 +47,8 @@
end

java_ark "jdk-alt" do
url tarball_url
url node['java']['set_default']

This comment was marked as outdated.

@cantenesse
Copy link
Contributor Author

Fixed, sorry about that.

carmstrong added a commit that referenced this pull request Feb 24, 2014
added support to determine whether to set installed java version to defa...
@carmstrong carmstrong merged commit 3258352 into sous-chefs:master Feb 24, 2014
@carmstrong
Copy link
Contributor

👍

@carmstrong
Copy link
Contributor

@cantenesse could you also update README.md to reference the newly-created attribute?

@cantenesse
Copy link
Contributor Author

Will do.
On Feb 25, 2014 7:18 PM, "Christopher Armstrong" notifications@github.com
wrote:

@cantenesse https://github.com/cantenesse could you also update
README.md to reference the newly-created attribute?

Reply to this email directly or view it on GitHubhttps://github.com//pull/140#issuecomment-36086850
.

@lock
Copy link

lock bot commented Oct 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants