Specify windows attributes in attribute files #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves windows attributes back to the attribute file. sous-chefs#95 moved these to the recipe, however that prevents setting these attributes in a wrapper cookbook's attribute file. This ensures that only attributes which depend on jdk_version are set in the recipe. All other attributes are set in the attribute file like normal.
carmstrong
added a commit
that referenced
this pull request
Dec 17, 2013
Specify windows attributes in attribute files
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in #95. Setting attributes in the recipe (instead of the attribute file) prevents setting default attributes in wrapper cookbooks. I realize this was done so users could easily override
jdk_versionwithout having to override all attributes that depend onjdk_version.This ensures that only attributes which depend on
jdk_versionare set in the recipe. All other attributes are set in the attribute file like normal.This fixes windows installations where a user must specify a url and checksum.