support for MD5 checksum #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… format is automatically detected.
|
Curious what others think of this. It looks like Oracle only provides MD5 hashes. Should we change the cookbook to validate on MD5 only, or do we trust the SHA256 that we generate manually with each release? |
|
To make it easy and have backwards compatibility, this PR supports both and chooses the appropriate method depending on the format of the checksum. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oracle provides MD5 checksum for jdk downloads: http://www.oracle.com/technetwork/java/javase/downloads/java-se-binaries-checksum-1956892.html
The cookbook currently only supports SHA256. This pull request parses the format of the checksum and automatically uses SHA256 or MD5 to verify the downloaded file. That way the checksum provided by oracle may be used directly, while maintaining support for SH256.