Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP FileShare Support] Fix for Invalid memory address or nil pointer dereference for GCP Fileshare Creation #1105

Merged
merged 11 commits into from
Sep 27, 2020

Conversation

himanshuvar
Copy link
Member

What type of PR is this?

/kind bug fix

What this PR does / why we need it: This PR will fix for nil pointer derefence for FileShare resouces in the service layer

Which issue(s) this PR fixes:

Fixes #1104

Test Report Added?:

/kind TESTED

Test Report:

image

Special notes for your reviewer:

@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #1105 into master will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1105      +/-   ##
==========================================
- Coverage   48.09%   48.03%   -0.07%     
==========================================
  Files          10       10              
  Lines        1420     1422       +2     
==========================================
  Hits          683      683              
- Misses        687      689       +2     
  Partials       50       50              
Impacted Files Coverage Δ
file/pkg/service/service.go 23.00% <0.00%> (-0.15%) ⬇️

openapi-spec/swagger.yaml Outdated Show resolved Hide resolved
openapi-spec/swagger.yaml Show resolved Hide resolved
Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skdwriting skdwriting merged commit e944af2 into sodafoundation:master Sep 27, 2020
Copy link
Collaborator

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GCP FileShare Support] Invalid memory address or nil pointer dereference for GCP Fileshare Creation
3 participants