Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSI] Missing unit test and functional test in csi module #214

Open
leonwanghui opened this issue Apr 25, 2019 · 5 comments · May be fixed by #244
Open

[CSI] Missing unit test and functional test in csi module #214

leonwanghui opened this issue Apr 25, 2019 · 5 comments · May be fixed by #244
Assignees

Comments

@leonwanghui
Copy link
Collaborator

leonwanghui commented Apr 25, 2019

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

What happened:
I found there is a csi-test project located in kubernetes-csi code repo, I think it's required to import that project into csi module and trigger that in ci environment.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:
@xing-yang Please take a look at that project.

Environment:

  • NBP version:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@xing-yang
Copy link
Collaborator

xing-yang commented Apr 25, 2019

@leonwanghui Yes, it is good to use csi-test to test CSI plugin. It validates that a CSI plugin implementation follows CSI spec. We should add this task.

@xing-yang
Copy link
Collaborator

@wisererik

@xing-yang
Copy link
Collaborator

Here are instructions on how to use the sanity test package to test CSI drivers: https://github.com/kubernetes-csi/csi-test/tree/master/pkg/sanity

@wisererik
Copy link
Collaborator

Sure, I saw that, @jackhaibo please add test for CSI

@skdwriting
Copy link
Collaborator

@wisererik @jackhaibo any update on this?

@skdwriting skdwriting added the CAPRI Handle by June 18th 2019 for CAPRI release label Jun 13, 2019
@skdwriting skdwriting added backlog Backlog items - consider in the planning for next release and removed CAPRI Handle by June 18th 2019 for CAPRI release labels Jun 14, 2019
@jackhaibo jackhaibo linked a pull request Jul 12, 2019 that will close this issue
@skdwriting skdwriting added this to the Daito SODA v1.0 milestone Oct 25, 2019
@wisererik wisererik changed the title Missing unit test and functional test in csi module [CSI] Missing unit test and functional test in csi module Oct 25, 2019
@wisererik wisererik added enhancement and removed backlog Backlog items - consider in the planning for next release labels Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants