Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Volume Service is getting created with duplicate name #84

Open
satya-gorli opened this issue Jun 25, 2019 · 2 comments · May be fixed by #92
Open

Volume Service is getting created with duplicate name #84

satya-gorli opened this issue Jun 25, 2019 · 2 comments · May be fixed by #92
Milestone
Daito SODA v1.0

Comments

@satya-gorli
Copy link

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
What happened:

  1. Create Volume service with a name
  2. Repeat step1 with same name
  3. Its succeeded and displayed.
    What you expected to happen:
  4. Should prevent Service with same name
  5. Should have validation at client side and server side
    Orchestration-volume creation with duplicate name

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Orchestration(release/branch) version:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@kumarashit
Copy link
Collaborator

The schema allows to have the instance name repeated. But they will have different Ids. This is the reason we have the description also which for same name instance admin can differentiate based upon the description. It's mostly the onus of service creator, as of now.

@kumarashit kumarashit linked a pull request Jul 5, 2019 that will close this issue
Open
@kumarashit
Copy link
Collaborator

Changes are up for review

@skdwriting skdwriting added this to the Daito SODA v1.0 milestone Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Daito SODA v1.0
Development

Successfully merging a pull request may close this issue.

Adding unique constraint on the service name kumarashit/orchestration
3 participants
@skdwriting @kumarashit @satya-gorli