Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when 0 gravity in root Node #557

Closed
epernod opened this issue Jan 5, 2018 · 3 comments
Closed

Bug when 0 gravity in root Node #557

epernod opened this issue Jan 5, 2018 · 3 comments
Labels
issue: bug (major) Critical bug affecting everyone: not working, performances or accuracy degraded
Milestone

Comments

@epernod
Copy link
Contributor

epernod commented Jan 5, 2018

Take for example the scene: Demos/Liver.scn
Change the gravity of the root node:

As soon as the simulation start, the liver disappears... No error message in the console, neither on the components.

Does someone has an idea?


Suggested labels:

@epernod epernod added the issue: bug (major) Critical bug affecting everyone: not working, performances or accuracy degraded label Jan 5, 2018
@epernod epernod added this to the v17.12 milestone Jan 5, 2018
@epernod
Copy link
Contributor Author

epernod commented Jan 5, 2018

This bug has been introduce in the last month approx.

@hugtalbot
Copy link
Contributor

Hi @epernod
Yes this is due to my PR #521 about the CG
My fix was wrong the PR #556 should fix it (you can give it a try!).

If I'm right, the problem was that with no gravity, there was no external forces applied and the b vector was null. Then, in CG, the denominator den=pMp where p=b at first iteration was therefore den=0. Finally, a division by 0 is done, generating NaN positions in the MO. That's why your liver disappears.

@damienmarchal
Copy link
Contributor

The PR are merged...so it should work.

If it doesn't feel free to reopen if you still have the problem.
Thank you all for the bug report & solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug (major) Critical bug affecting everyone: not working, performances or accuracy degraded
Projects
None yet
Development

No branches or pull requests

3 participants