Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RouteTable#refreshConfiguration lost learner list. #815

Closed
haoyann opened this issue Apr 17, 2022 · 3 comments
Closed

RouteTable#refreshConfiguration lost learner list. #815

haoyann opened this issue Apr 17, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@haoyann
Copy link
Contributor

haoyann commented Apr 17, 2022

Your question

RouteTable#refreshConfiguration lost learner list,.So get learner list from RouteTable is empty, there will be some confusion.

final CliRequests.GetPeersResponse resp = (CliRequests.GetPeersResponse) result;
final Configuration newConf = new Configuration();
for (final String peerIdStr : resp.getPeersList()) {
final PeerId newPeer = new PeerId();
newPeer.parse(peerIdStr);
newConf.addPeer(newPeer);
}

Your scenes

Describe your use scenes (why need this feature)

Your advice

RouteTable#refreshConfiguration also refresh learner list.

Environment

  • SOFAJRaft version:
  • JVM version (e.g. java -version):
  • OS version (e.g. uname -a):
  • Maven version:
  • IDE version:
@horizonzy horizonzy assigned horizonzy and unassigned horizonzy Apr 17, 2022
@horizonzy horizonzy added enhancement New feature or request good first issue Good for newcomers labels Apr 17, 2022
@haoyann
Copy link
Contributor Author

haoyann commented Apr 18, 2022

I want to contribute this issue.

@horizonzy horizonzy assigned horizonzy and haoyann and unassigned horizonzy Apr 18, 2022
@fengjiachun
Copy link
Contributor

Thank you and send a PR please. @haoyann

@haoyann
Copy link
Contributor Author

haoyann commented Apr 19, 2022

PR merged close.

@haoyann haoyann closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants