-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support no_std on windows #49
Comments
@Plecra Could you say what the use case is for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
atty/src/lib.rs
Line 131 in 7b5df17
By replacing this vector with an array, we can remove the std dependency. The allocation is only 524 bytes long, and it wouldn't be unreasonable to allocate it on the stack (Rust's default stack size is 2MiB, giving us plenty of room).
We'd also need to remove the utf16 conversion that allocates to a string here:
atty/src/lib.rs
Line 146 in 7b5df17
One solution would simply be to write
s.contains(&[b'-' as u16, 'p' as _, 't' as _, 'y' as _])
, but there's also https://docs.rs/utf16_lit which makes this more readableThe text was updated successfully, but these errors were encountered: