Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry HttpDispatch & ThrottlingException errors #158

Open
DarrenTsung opened this issue Jun 10, 2021 · 1 comment
Open

Retry HttpDispatch & ThrottlingException errors #158

DarrenTsung opened this issue Jun 10, 2021 · 1 comment

Comments

@DarrenTsung
Copy link

💡 Feature description

Hi, thanks for the great library! We've seen spurious HttpDispatch errors (connection reset, DNS lookup failures) in production and it'd be nice if the Dynomite retry policy handled this for us in addition to the DynamoDB errors.

💻 Basic example

I've made this change in a fork: figma@70db2e0.

@DarrenTsung DarrenTsung changed the title Retry HttpDispatch errors Retry HttpDispatch & ThrottlingException errors Jun 10, 2021
@DarrenTsung
Copy link
Author

I also noticed that while Dynomite's retry policy will retry errors like TransactWriteItemsError::ProvisionedThroughputExceeded, it doesn't retry throttling errors which appear to be classified as RusotoError::Unknown(_).

The response body for the http request looks like:

{\"__type\":\"com.amazon.coral.availability#ThrottlingException\",\"message\":\"Throughput
exceeds the current capacity of your table or index. DynamoDB is
automatically scaling your table or index so please try again shortly.
If exceptions persist, check if you have a hot key:
https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/bp-partition-key-design.html\"}"

I've updated the fork with a fix for this as well:
figma@3eb298e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant