Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network inspect type #294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cswinter
Copy link
Contributor

What did you implement:

Fixes return type of network inspect function.

Closes: #293

How did you verify your change:

Tested manually, before change inspect returns parse error, after change, it returns valid network info.

What (if anything) would need to be called out in the CHANGELOG for the next release:

  • Fix network inspect function

@cswinter
Copy link
Contributor Author

@softprops I think you need to manually kick off build for this PR: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

network inspect tries to parse response as NetworkInfo, should be NetworkDetails
1 participant