Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build arguments support #327

Open
Molter73 opened this issue Nov 8, 2022 · 1 comment
Open

Add build arguments support #327

Molter73 opened this issue Nov 8, 2022 · 1 comment

Comments

@Molter73
Copy link

Molter73 commented Nov 8, 2022

Hi everyone! I'm using shiplift in a small side project in which I build docker images and run them as self contained development environments. Today I realized one of my dockerfiles had an ARG statement and I have no way to set it through shiplift. Has someone looked into adding support for the buildargs parameter of the docker API? I have not been able to find an issue related to this. https://docs.docker.com/engine/api/v1.41/#tag/Image/operation/ImageBuild

From what I can tell we would need to add a build_arg method to BuildOptionsBuilder that takes the key and values. The problem I see is build_arg could be called multiple times and BuildOptionsBuilder has a params hash map that can only accept strings, so we would need to:

  • Have a single buildargs key and for every call to build_arg do some string manipulation to add the new argument.
  • Have a separate buildargs hash map in BuildOptionsBuilder, add key/value pairs directly in there and serialize it separately from the rest of the arguments.

Would love to hear some feedback on this, maybe even put together a PR if it sounds good to the community 😄

@Molter73
Copy link
Author

Molter73 commented Nov 8, 2022

Just in case, I have a quick and dirty change for this commited here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant