Skip to content

Commit 80147ce

Browse files
authored
fix: remove client recv msg limit (googleapis#704)
1 parent f28b43d commit 80147ce

File tree

6 files changed

+44
-0
lines changed

6 files changed

+44
-0
lines changed

gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/transports/grpc.py.j2

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,10 @@ class {{ service.name }}GrpcTransport({{ service.name }}Transport):
124124
ssl_credentials=ssl_credentials,
125125
scopes=scopes or self.AUTH_SCOPES,
126126
quota_project_id=quota_project_id,
127+
options=[
128+
("grpc.max_send_message_length", -1),
129+
("grpc.max_receive_message_length", -1),
130+
],
127131
)
128132
self._ssl_channel_credentials = ssl_credentials
129133
else:
@@ -138,6 +142,10 @@ class {{ service.name }}GrpcTransport({{ service.name }}Transport):
138142
credentials=credentials,
139143
ssl_credentials=ssl_channel_credentials,
140144
scopes=self.AUTH_SCOPES,
145+
options=[
146+
("grpc.max_send_message_length", -1),
147+
("grpc.max_receive_message_length", -1),
148+
],
141149
)
142150

143151
self._stubs = {} # type: Dict[str, Callable]

gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -748,6 +748,10 @@ def test_{{ service.name|snake_case }}_transport_channel_mtls_with_client_cert_s
748748
),
749749
ssl_credentials=mock_ssl_cred,
750750
quota_project_id=None,
751+
options=[
752+
("grpc.max_send_message_length", -1),
753+
("grpc.max_receive_message_length", -1),
754+
],
751755
)
752756
assert transport.grpc_channel == mock_grpc_channel
753757
assert transport._ssl_channel_credentials == mock_ssl_cred
@@ -787,6 +791,10 @@ def test_{{ service.name|snake_case }}_transport_channel_mtls_with_adc(
787791
),
788792
ssl_credentials=mock_ssl_cred,
789793
quota_project_id=None,
794+
options=[
795+
("grpc.max_send_message_length", -1),
796+
("grpc.max_receive_message_length", -1),
797+
],
790798
)
791799
assert transport.grpc_channel == mock_grpc_channel
792800

gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,10 @@ class {{ service.name }}GrpcTransport({{ service.name }}Transport):
132132
ssl_credentials=ssl_credentials,
133133
scopes=scopes or self.AUTH_SCOPES,
134134
quota_project_id=quota_project_id,
135+
options=[
136+
("grpc.max_send_message_length", -1),
137+
("grpc.max_receive_message_length", -1),
138+
],
135139
)
136140
self._ssl_channel_credentials = ssl_credentials
137141
else:
@@ -148,6 +152,10 @@ class {{ service.name }}GrpcTransport({{ service.name }}Transport):
148152
ssl_credentials=ssl_channel_credentials,
149153
scopes=scopes or self.AUTH_SCOPES,
150154
quota_project_id=quota_project_id,
155+
options=[
156+
("grpc.max_send_message_length", -1),
157+
("grpc.max_receive_message_length", -1),
158+
],
151159
)
152160

153161
self._stubs = {} # type: Dict[str, Callable]

gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc_asyncio.py.j2

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,10 @@ class {{ service.grpc_asyncio_transport_name }}({{ service.name }}Transport):
176176
ssl_credentials=ssl_credentials,
177177
scopes=scopes or self.AUTH_SCOPES,
178178
quota_project_id=quota_project_id,
179+
options=[
180+
("grpc.max_send_message_length", -1),
181+
("grpc.max_receive_message_length", -1),
182+
],
179183
)
180184
self._ssl_channel_credentials = ssl_credentials
181185
else:
@@ -192,6 +196,10 @@ class {{ service.grpc_asyncio_transport_name }}({{ service.name }}Transport):
192196
ssl_credentials=ssl_channel_credentials,
193197
scopes=scopes or self.AUTH_SCOPES,
194198
quota_project_id=quota_project_id,
199+
options=[
200+
("grpc.max_send_message_length", -1),
201+
("grpc.max_receive_message_length", -1),
202+
],
195203
)
196204

197205
# Run the base constructor.

gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,10 @@ class {{ service.name }}RestTransport({{ service.name }}Transport):
101101
self._host,
102102
credentials=self._credentials,
103103
scopes=self.AUTH_SCOPES,
104+
options=[
105+
("grpc.max_send_message_length", -1),
106+
("grpc.max_receive_message_length", -1),
107+
],
104108
)
105109
)
106110

gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1237,6 +1237,10 @@ def test_{{ service.name|snake_case }}_transport_channel_mtls_with_client_cert_s
12371237
),
12381238
ssl_credentials=mock_ssl_cred,
12391239
quota_project_id=None,
1240+
options=[
1241+
("grpc.max_send_message_length", -1),
1242+
("grpc.max_receive_message_length", -1),
1243+
],
12401244
)
12411245
assert transport.grpc_channel == mock_grpc_channel
12421246
assert transport._ssl_channel_credentials == mock_ssl_cred
@@ -1276,6 +1280,10 @@ def test_{{ service.name|snake_case }}_transport_channel_mtls_with_adc(
12761280
),
12771281
ssl_credentials=mock_ssl_cred,
12781282
quota_project_id=None,
1283+
options=[
1284+
("grpc.max_send_message_length", -1),
1285+
("grpc.max_receive_message_length", -1),
1286+
],
12791287
)
12801288
assert transport.grpc_channel == mock_grpc_channel
12811289

0 commit comments

Comments
 (0)