Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify branch restrictions or rulesets for PR review requirements #3

Closed
d33bs opened this issue Mar 9, 2024 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@d33bs
Copy link
Member

d33bs commented Mar 9, 2024

FWIW, it might be worth specifying how many approvals by maintainers you need to merge items - for example, I don't think all three of us need to. (The waylab only requires one approval, FWIW)

Originally posted by @gwaybio in #2 (review)

@d33bs: I took a quick look at enabling required 1 review per PR for all repositories in the organization and found that rulesets appear to be the quickest way to enable this. I created a ruleset for the organization, but it appears that we cannot enforce it without Enterprise access to GitHub. I'm going to explore the avenues to Enterprise access and alongside this what the impact might be of using branch rules at the repo level.

@d33bs
Copy link
Member Author

d33bs commented Mar 19, 2024

The Software Gardening GitHub organization has been added to the University of Colorado's Enterprise account. The ruleset created for required number of reviews at the organizational level now functions as expected. I expect this to function across any other repositories within the organization as well. Closing this out under that assumption.

See below from software-gardening/almanack#7:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant