Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate argument code for TGSL functions based on the shell, not on the AST. #658

Open
iwoplaza opened this issue Dec 17, 2024 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@iwoplaza
Copy link
Collaborator

Currently, resolving the following function will generate a WGSL function with no arguments:

tgpu
  .fn([d.arrayOf(d.f32, gridSize)])
  .does(() => {
    // do something
  })
  .$name('fill');

That's because the arguments are based on what's in the AST, and not what's in the shell.
Arguments omitted from the AST should be given unique but random names, like param_0, param_1, etc...

@iwoplaza iwoplaza added the bug Something isn't working label Dec 17, 2024
@iwoplaza iwoplaza added this to the 0.5.0 - TGSL milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant