Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI and enable ts-check for browser-render #869

Open
BrtqKr opened this issue Nov 19, 2024 · 1 comment
Open

Fix CI and enable ts-check for browser-render #869

BrtqKr opened this issue Nov 19, 2024 · 1 comment
Assignees
@wkozyra95
Labels
bug Something isn't working

Comments

@BrtqKr
Copy link
Collaborator

BrtqKr commented Nov 19, 2024 •
edited
Loading

"typecheck": "pnpm -r --filter '!@live-compositor/browser-render' run typecheck",
There's a different wasm generated on CI from the one generated locally. Just fix it and remove the filter option when the whole thing is done.
@BrtqKr BrtqKr added the bug Something isn't working label Nov 19, 2024
@BrtqKr BrtqKr changed the title Enable ts-check for browser-render Fix CI and enable ts-check for browser-render Nov 19, 2024
@wkozyra95
Copy link
Member

Partially fixed in #870 (proper fix will be to update wasm-bindgen when they release new version)

We can't downgrade to working version right now without reverting wgpu upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkozyra95 wkozyra95

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wkozyra95 @BrtqKr