Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac Catalyst Support #76

Open
mqtik opened this issue Dec 26, 2024 · 2 comments
Open

Mac Catalyst Support #76

mqtik opened this issue Dec 26, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mqtik
Copy link

mqtik commented Dec 26, 2024

Problem description

Trying to run the app on Catalyst on XCode yields:
/node_modules/react-native-executorch/ios/RnExecutorch.mm:2:9 'LLaMARunner/LLaMARunner.h' file not found

Proposed solution

Adding support in Info.plist like this:

<dict>
			<key>BinaryPath</key>
			<string>LLaMARunner.framework/LLaMARunner</string>
			<key>LibraryIdentifier</key>
			<string>maccatalyst-arm64</string>
			<key>LibraryPath</key>
			<string>LLaMARunner.framework</string>
			<key>SupportedArchitectures</key>
			<array>
				<string>arm64</string>
			</array>
			<key>SupportedPlatform</key>
			<string>maccatalyst</string>
		</dict>

And probably making another slice for maccatalyst aside of ios-arm64.
Not sure of the scope to make this work.

Alternative solutions

No response

Benefits to React Native ExecuTorch

If it's something that can get fixed easily, allowing Mac Catalyst to build the app with Executorch support would be awesome.

Additional context

No response

@mkopcins mkopcins added the enhancement New feature or request label Dec 29, 2024
@mkopcins
Copy link
Collaborator

We will need to look into this, depending on the time effort required we might fit this in the future plans

@mqtik
Copy link
Author

mqtik commented Jan 23, 2025

Thanks @mkopcins
I'll stay tuned! Let me know if I can help in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants