Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug][ios] 3.14+ breaks all ScrollViews/FlatList when inside a stack with fullScreenGestureEnabled #1510

Closed
3 of 9 tasks
hirbod opened this issue Jul 4, 2022 · 4 comments · Fixed by #1512
Closed
3 of 9 tasks
Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided

Comments

@hirbod
Copy link
Contributor

hirbod commented Jul 4, 2022

Description

Hi @WoLewicki, I hold up to my promise to find every bug in RNS :D

After the update to 3.14.1 it is impossible to scroll in a view (ScrollView, FlatList etc) with fullScreenGestureEnabled.

The gesture recognizer takes total control and does not allow scrolling anymore. If you set fullScreenGestureEnabled: false, it works.

The problem does not occur with 3.13.1. I suspect the regression comes from #1370

Screenshots

3.13.1 (works) 3.14.1 (broken)
RPReplay_Final1656971534.mp4
RPReplay_Final1656972684.mp4

Steps To Reproduce

  1. Create a Stack Screen with fullScreenGestureEnabled.
  2. Add ScrollView inside of it and navigate to it
  3. Try to scroll - impossible. The horizontal pop gesture kicks in

Expected behavior

Should not break scrolling. Also messes around with react-native-gesture-handlers activeOffsetY. If set to -20, 20, it does also not work anymore, had to change it to -5, 5.

Actual behavior

Scrolling impossible with fullScreenGestureEnabled
Breaks scrolling

Reproduction

https://snack.expo.dev/@hirbod/scrollview

Just drop the ScrollView inside a Screen with fullScreenGestureEnabled set too true. Since Snack does not Support 3.14.1, it's not a real repro.

Platform

  • iOS
  • Android
  • Web
  • Windows
  • tvOS

Architecture

  • Paper
  • Fabric

Workflow

  • Managed workflow
  • Bare workflow

Package versions

package version
react-native 0.68.2
@react-navigation/native 6.0.10
@react-navigation/native-stack 6.6.2
react-native-screens 3.14.1
react-native-safe-area-context 4.3.1
react-native-gesture-handler 2.4.2
react-native-reanimated 2.8.0
expo SDK 45 (custom dev client)
@github-actions github-actions bot added Repro provided A reproduction with a snack or repo is provided Platform: iOS This issue is specific to iOS labels Jul 4, 2022
@hirbod hirbod changed the title [bug][ios][IMPORTANT] 3.14+ breaks all ScrollViews/FlatList when inside a stack with fullScreenGestureEnabled [bug][ios] 3.14+ breaks all ScrollViews/FlatList when inside a stack with fullScreenGestureEnabled Jul 4, 2022
@kkafar
Copy link
Member

kkafar commented Jul 5, 2022

Quite a bug. Looking into this.

@hirbod
Copy link
Contributor Author

hirbod commented Jul 6, 2022

I confirm the issue is fixed after pulling in the PR

@chazzaoui
Copy link

Thank you for resolving this issue so quickly! @kkafar
Do you have an idea when we can expect a release with this fix?

@kkafar
Copy link
Member

kkafar commented Jul 6, 2022

@chazzaoui
We're planning to do the release tomorrow, as there are some more changes we want to introduce. But don't cling to this date, if we'll wind more issues there might be a slight delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants