Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] large title on scroll & on orientation change weird behavior ? #990

Closed
a-eid opened this issue Jun 18, 2021 · 8 comments
Closed

[ios] large title on scroll & on orientation change weird behavior ? #990

a-eid opened this issue Jun 18, 2021 · 8 comments

Comments

@a-eid
Copy link

a-eid commented Jun 18, 2021

Description

Screenshots

on scroll
on orientation

Package versions

  • React: 17.0.1
  • React Native: 0.64.2
  • React Native Screens: ^3.4.0
@kacperkapusciak
Copy link
Member

Can you please provide a minimal complete reproducible code sample?

@a-eid
Copy link
Author

a-eid commented Jun 21, 2021

Will provide one, but I've literally done nothing other than adding the title

@a-eid
Copy link
Author

a-eid commented Jun 24, 2021

will reopen with a reproducible example repo.

@a-eid a-eid closed this as completed Jun 24, 2021
@a-eid
Copy link
Author

a-eid commented Jun 25, 2021

this repo include a reproducible example of the issue(s)

https://github.com/a-eid/RNSBug

large title goes off screen when orientation change.

not sure how to describe the second issue but the large title should animate back to large since the scrollview is empty,

@a-eid a-eid reopened this Jun 25, 2021
@WoLewicki
Copy link
Member

About the second issue, see: #320 (comment). About the

large title goes off screen when orientation change.

I am not sure what do you mean by it. In the repro, the header transitions normally landscape-portrait both on simulator and physical phone. I haven't been able to reproduce the behavior from the provided GIF.

@a-eid
Copy link
Author

a-eid commented Jul 5, 2021

I will re test on a none m1 machine and a physical device

@a-eid a-eid closed this as completed Jul 5, 2021
@a-eid a-eid reopened this Jul 30, 2021
@a-eid
Copy link
Author

a-eid commented Jul 30, 2021

@WoLewicki I am still seeing the first (gif) issue when using a tabbar, for the first tab the large header look to work fine, but for other tabs it does not.

large-title-issue.mp4

@a-eid a-eid closed this as completed Jul 30, 2021
@WoLewicki
Copy link
Member

@a-eid is it still the issue? Or did you close it on purpose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants