Support RPC 0.8.0 #530
Draft
Support RPC 0.8.0 #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructured-error-trace
franciszekjob
commented
Oct 23, 2024
Comment on lines
665
to
677
| /** | ||
| * Get merkle paths in one of the state tries. | ||
| * | ||
| * Get merkle paths in one of the state tries: global state, classes, individual contract. | ||
| * | ||
| * @param classHashes list of class hashes for which we want to prove membership | ||
| * @param contractAddresses list of contract addresses for which we want to prove membership | ||
| * @param contractsStorageKeys list of contract address and storage keys pairs | ||
| * | ||
| * @throws RequestFailedException | ||
| */ | ||
| fun getStorageProof(classHashes: List<Felt>? = null, contractAddresses: List<Felt>? = null, contractsStorageKeys: List<ContractStorageKey>? = null): Request<StorageProof> | ||
|
|
There was a problem hiding this comment.
note: It's a bit exceptional situation, due to the fact that creating overloads would cause a conflict, e.g. for
fun getStorageProof(classHashes: List<Felt>, contractsStorageKeys: List<ContractStorageKey>): Request<StorageProof>and
fun getStorageProof(contractAddresses: List<Felt>, contractsStorageKeys: List<ContractStorageKey>): Request<StorageProof>(compiler won't know which method to use, contractAddresses and classHashes are of the same type). So unfortunately we need to add default values here.
|
note: This PR is still wip.
|
DelevoXDG
reviewed
Oct 25, 2024
lib/src/main/kotlin/com/swmansion/starknet/account/StandardAccount.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/data/types/Responses.kt
Outdated
Show resolved
Hide resolved
franciszekjob
commented
Oct 28, 2024
Comment on lines
+10
to
+21
| override fun selectDeserializer(element: JsonElement): DeserializationStrategy<NodeHashToNodeMappingItem.MerkleNode> { | ||
| val jsonElement = element.jsonObject | ||
| val binaryNodeKeys = NodeHashToNodeMappingItem.BinaryNode.serializer().descriptor.elementNames.toSet() | ||
| val edgeNodeKeys = NodeHashToNodeMappingItem.EdgeNode.serializer().descriptor.elementNames.toSet() | ||
|
|
||
| return when (jsonElement.keys) { | ||
| binaryNodeKeys -> NodeHashToNodeMappingItem.BinaryNode.serializer() | ||
| edgeNodeKeys -> NodeHashToNodeMappingItem.EdgeNode.serializer() | ||
| else -> throw IllegalArgumentException("Invalid MerkleNode JSON object: $jsonElement") | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
note: We could potentially give an error with more meaningful message (saying which fields are missing and if it's binary/edge node). However, in case of json with keys that belong both to binary and edge node
e.g.
{
"left": ...,
"path": ...
}
we can't clearly decide which type it is intended to be (binary/edge). I'm not fully sure if such logic is worth introducing.
A simple improvement would be to display required keys for binary/edge nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Support RPC 0.8.0.
starknet_getStorageProofStorageProof,GlobalRoots,ContractsProof,ContractLeafData,NodeHashToNodeMappingItem,BinaryNode,EdgeNode,ContractStorageKeydata classesgetStorageProofmethod inProviderandJsonRpcProviderstarknet_getMessagesStatusMessageStatusList,MessageStatusdata classesgetMessagesStatusmethod inProviderandJsonRpcProviderAccount,StandardAccount:signDeployAccountV3andexecuteV3have nowresourceBoundsparam instead ofl1ResourceBoundsInvokeParamsV3,DeclareParamsV3,DeployAccountParamsV3:l1ResourceBoundsparam toresourceBoundsin constructorEstimateFeeResponse:gasConsumedtol1GasConsumedgasPricetol1GasPricedataGasPricetol1DataGasPricedataGasConsumedtol1DataGasConsumedl2GasConsumed,l2GasPricefieldsComputationResourcesand updateExecutionResourcesInnerCallExecutionResourcesl1GasinResourceBoundsMappingcomputationResourcestoexecutionResourcesinFunctionInvocationand change its type toInnerCallExecutionResourcesinstead ofComputationResourcesResourceBoundsMapping.ZEROfailureReasontoGetTransactionStatusResponseLinked issues
Closes #519
Breaking changes
resourceBoundsinstead ofl1ResourceBoundsparamComputationResourceshas been removed;ExecutionResourcesandEstimateFeeResponsehave been updated