-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This project is working but seems outdated. Which fork to use? #251
Comments
Looks like it. Will fix it later today. |
@siemiatj Perhaps it's better to create a new repo and not a fork, since it's not possible to open issues there. Also, I am not able to run the example. Is it possible to upgrade the example to 0.62.2? |
Created a clone repo (same url) and will use that from now on. |
Thanks @siemiatj. And you kept the old fork for history here: https://github.com/siemiatj/react-native-modal-dropdown-legacy I will create an issue in the new one. |
We should change the conencted repository on npm packages to @siemiatj's one. |
I believe repository is simply taken from Edit: Found more on taking over packages here: https://wlach.github.io/blog/2017/07/taking-over-an-npm-package-sanity-prevails/ it might be a matter of one email. |
I think it'd be easiest to just create a new npm package as @sohobloo seems to have abandoned this ship. But I'll try to reach out to both him and npm first. |
@Bilal-Abdeen Thanks a lot for suggestion. It works! I added it in my project and it works! Thanks a lot! |
Thanks, @siemiatj . If you can't update this package by contacting npm, you really should upload your version as a new package. |
I've just upgraded my app to RN 0.63.2 and added the @siemiatj version - all works apart from nothing happens when I select a row - any ideas what's causing that? |
@siemiatj Updating the dropdown options dynamically shows loading icon instead of the updated options. |
Had the same problem. I removed TouchableOpacity that was wrapping my component passed to renderRow prop. |
Try this, added support for right component / dropdown icon and full width |
@Kishanjvaghela do you want to provide your new features as PR to https://github.com/siemiatj/react-native-modal-dropdown? |
@siemiatj any news about the npm package? It feels like it's time to move on. Not trying to push, just showing interest for this thing to be sorted out. |
Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details. |
Please update the following components: %s, ModalDropdown |
@tim92109 Please read the comments (or the topic of the discussion you are posting to) first. This project is outdated. Most actively maintained fork can be found here: https://github.com/siemiatj/react-native-modal-dropdown |
@kub1x ok thx |
Just wanted to let you know that I successfully took over the npm package and published a new version under the same name. |
Awesome @siemiatj ! Stoked to use it again |
Hello guys, is there any way I can know which option is selected at a given moment ? I've been struggling , haven't figured it out yet |
You can use the |
Thanks for the help, got it. |
I found different forks in the issues here and I ask myself, which one to use. All seems to have implemented the
FlatList
instead ofListView
to address certain problems.3 seems to be mostly updated. 2 seems to be more up to date than 1.
From this point of view, I would go with @siemiatj's version?
There is an open issue, created one month ago: #247 Is this a blocker?
The text was updated successfully, but these errors were encountered: