New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenCL sigverify needs extra malleability signature checks #80

Open

sakridge opened this issue Sep 1, 2020 · 0 comments

Member

sakridge commented Sep 1, 2020 •

edited

Loading

Extra checks were added to the cuda sigverify for signature malleability:

solana-perf-libs/src/cuda-ecc-ed25519/verify.cu

Line 89 in ccb3a0e

check_packed_ge_small_order(const unsigned char* packed_group_element) {

solana-perf-libs/src/cuda-ecc-ed25519/verify.cu

Line 119 in ccb3a0e

if (0 != get_checked_scalar(checker, signature + 32)) {

These should be added to the OpenCL implementation as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment