fix: splice bytes in-place when reading buffers

[steveluscher]

Summary

I noticed many places where we:

1. Read a section of bytes from an array, from index A-B
2. Overwrite the entire byte array with the bytes from B onward

This is done in two steps using Array#slice twice. What we're looking for here is the mutative, one-step Array#slice.

Test Plan

CI run

[changeset-bot]

⚠️ No Changeset found

Latest commit: 40fff87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[steveluscher]

• fix: splice bytes in-place when reading buffers #2315 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite

[github-actions]

🎉 This PR is included in version 1.91.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.