-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cover logs error for ws message #3392
fix: cover logs error for ws message #3392
Conversation
|
This is a good change. This does not of course solve the problem of the subscription system endlessly looping when it encounters an error like this. Consider this: import { Connection } from '@solana/web3.js';
const connection = new Connection('https://api.devnet.solana.com');
connection.onAccountChange({ toBase58() { return '1'.repeat(31); }}, console.log); This invalid pubkey will generate a JSON-RPC error:
But then the thing will loop forever, retrying the subscription endlessly. The problem is that this API has no practical way to communicate subscription failure to the client. This has been fixed in |
e345937
into
solana-labs:maintenance/v1.x
🎉 This PR is included in version 1.95.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks, for explanation, of course this changes just for notify developer what something wrong with subscribe, and I like about 2 version which fixes this behavior, will wait for stable release |
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Some message from websocket contain error
Which not present any where, just add console log for represent error for developer