Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Agave v2 RPC: replace getConfirmedBlock with getBlock #3417

Conversation

buffalojoec
Copy link
Contributor

@buffalojoec buffalojoec commented Oct 23, 2024

Problem

With the upcoming upgrade from 1.18 to 2.0 on Solana mainnet-beta, deprecated RPC methods have been removed, therefore they will no longer be available through Web3.js client requests.

The Agave 2.0 Migration Guide lists semi-equivalent RPC method counterparts for each of the removed methods.

Summary of Changes

Replace getConfirmedBlock with getBlock. This method was already requiring a confirmation level of confirmed or finalized, so the behavior should be unchanged.

Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: e730045

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@buffalojoec buffalojoec force-pushed the 10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_ branch from 6acd1dc to 22a65a5 Compare October 29, 2024 09:54
@github-actions github-actions bot added stale and removed stale labels Nov 13, 2024
@buffalojoec buffalojoec force-pushed the 10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_ branch from 22a65a5 to 77b6e59 Compare November 18, 2024 11:49
@buffalojoec buffalojoec force-pushed the 10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_ branch from 77b6e59 to c35251a Compare November 27, 2024 11:56
@buffalojoec buffalojoec force-pushed the 10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_ branch from c35251a to 6607d91 Compare December 6, 2024 07:26
@buffalojoec buffalojoec force-pushed the 10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_ branch from 6607d91 to e730045 Compare December 6, 2024 07:29
Copy link
Contributor Author

buffalojoec commented Dec 16, 2024

Merge activity

  • Dec 15, 11:14 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 15, 11:15 PM EST: A user merged this pull request with Graphite.

@buffalojoec buffalojoec merged commit 60e39a6 into maintenance/v1.x Dec 16, 2024
9 checks passed
@buffalojoec buffalojoec deleted the 10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_ branch December 16, 2024 04:15
Copy link
Contributor

🎉 This PR is included in version 1.96.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants