Override the @solana/web3.js transitive dependency of spl-token and buffer-layout-utils in a more targeted way

[steveluscher]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 43cb2e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[steveluscher]

• Override the @solana/web3.js transitive dependency of spl-token and buffer-layout-utils in a more targeted way #2815 👈
• Fixed a bug where the RPC coalescer would leave the application with no request even though there were consumers #2819 : 1 other dependent PR (#2821 )
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite

[mcintyre94]

Looks fine! What's the reason for this out of interest?

[buffalojoec]

Looks fine! What's the reason for this out of interest?

Agreed, where are we even using these libraries? The nice thing is this shouldn't ever break considering legacy will never reach 2.0!

[steveluscher]

OMG the reason is so dumb; it's because we use @solana/spl-token to create token accounts for the connection.test.ts in the legacy library.

Know what. I'm just going to replace those with test fixtures.

[steveluscher]

Abandoning this in favour of https://app.graphite.dev/github/pr/solana-labs/solana-web3.js/2821/Rewrite-the-legacy-token-tests-without-solana-spl-token

[github-actions]

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.