-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RecentBlockhashes sysvar needs to carry the full BlockhashQueue #10065
Comments
Is this an alternative? #10054 (comment) |
Yes, that's a good alternative. I'd be okay with closing this issue by adding detailed documentation saying that transactions with blockhashes not present in that list may still be in flight, but that leader nodes will reject the transaction; stop retrying, but DO NOT resign and resend yet! |
@mvines I think we should go ahead and do the bump when convenient. |
@t-nelson CC: according to recent talk with @aeyakovenko, we're going to align with 150, not 300 for more shorter tx expiration for less data retention. |
Problem
Need this to be all 300 blockhashes. If not in the 150, you can stop resending retries, but you can't yet resign and send a new transaction. To resign, you need to be sure the leader's block isn't still in flight. The RPC node will accept transaction if its blockhash is anywhere in that full 300.
Originally posted by @garious in #8632 (comment)
Suggested changes
Bump
recent_blockhashes::MAX_ENTRIES
toMAX_RECENT_BLOCKHASHES
NOTE: ABI breakage
cc/ @mvines @garious
The text was updated successfully, but these errors were encountered: