Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecentBlockhashes sysvar needs to carry the full BlockhashQueue #10065

Open
t-nelson opened this issue May 15, 2020 · 4 comments
Open

RecentBlockhashes sysvar needs to carry the full BlockhashQueue #10065

t-nelson opened this issue May 15, 2020 · 4 comments
Assignees
Milestone

Comments

@t-nelson
Copy link
Contributor

t-nelson commented May 15, 2020

Problem

Need this to be all 300 blockhashes. If not in the 150, you can stop resending retries, but you can't yet resign and send a new transaction. To resign, you need to be sure the leader's block isn't still in flight. The RPC node will accept transaction if its blockhash is anywhere in that full 300.

Originally posted by @garious in #8632 (comment)

Suggested changes

Bump recent_blockhashes::MAX_ENTRIES to MAX_RECENT_BLOCKHASHES
NOTE: ABI breakage

cc/ @mvines @garious

@mvines
Copy link
Member

mvines commented May 15, 2020

Is this an alternative? #10054 (comment)

@garious
Copy link
Contributor

garious commented May 15, 2020

Yes, that's a good alternative. I'd be okay with closing this issue by adding detailed documentation saying that transactions with blockhashes not present in that list may still be in flight, but that leader nodes will reject the transaction; stop retrying, but DO NOT resign and resend yet!

@t-nelson
Copy link
Contributor Author

@mvines I think we should go ahead and do the bump when convenient. MAX_PROCESSING_AGE is a non-consensus soft-cap, so using it here is giving it more weight than it deserves

@mvines mvines added this to the v1.3.0 milestone May 21, 2020
@mvines mvines modified the milestones: v1.3.0, v1.4.0 Aug 5, 2020
@mvines mvines modified the milestones: v1.4.0, v1.5.0 Oct 8, 2020
@mvines mvines modified the milestones: v1.5.0, v1.6.0 Dec 17, 2020
@ryoqun
Copy link
Member

ryoqun commented Feb 27, 2021

@t-nelson CC: according to recent talk with @aeyakovenko, we're going to align with 150, not 300 for more shorter tx expiration for less data retention.

@mvines mvines modified the milestones: v1.6.0, v1.7.0 Mar 11, 2021
@mvines mvines modified the milestones: v1.7.0, v1.8.0 May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants