Subscription Optimizations

[CriesofCarrots]

Problem

#10147 introduced separate subscription maps for gossip-triggered notifications, such that only subscriptions set with SingleGossip commitment are checked when a new single-confirmation slot is detected in gossip. This concept could be applied to the Bank-triggered notifications as well. Currently, when a node votes on a new Bank, the subscription service checks all Bank subscriptions, wasting effort if the known max, root, or highest confirmed slot has not actually changed.

Proposed Solution

Refactor Bank-triggered subscriptions to only check subscriptions with a commitment-level known to have changed. This would look something like:

• extend last_checked_slots cache to track max-, root-, and single-commitment checked slots
• index subscriptions by commitment level to easily check subsets; bring gossip_*_subscriptions back into the fold
• add subscription id lookup map to enable quick unsubscribe operations across commitment levels

cc @jstarry

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[stale]

This stale issue has been automatically closed. Thank you for your contributions.

[github-actions]

This issue has been automatically locked since there has not been any activity in past 7 days after it was closed. Please open a new issue for related bugs.