-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gossip proofs should be ingested into blockstore's, and used to notify ReplayStage of duplicates #16508
Comments
what's the size and rate of the proofs? cc/ @behzadnouri |
Oops, closed by accident, still need to add protection. |
The size is equal to 2 shreds, but because there are some metadata it spills over 3 packets. |
@wen-coding This is not being done yet
|
The plan ahead: Ashwin already has PR #32963 to notify state machine of duplicate proofs, but this can't be done until we fix the switching proof. So roll that out after the switching proof is fixed. @AshwinSekar Does that look right? |
Problem
Gossip proofs are propagated but not currently:
store_duplicate_if_not_existing()
only runs on received shreds from WindowService)This is an issue if some nodes see duplicates and others don't.
Proposed Solution
The text was updated successfully, but these errors were encountered: