web3.js: When maxRetries is set to zero, it's stripped out

[steveluscher]

Problem

This code will fail to send the maxRetries parameter when it's zero.

https://github.com/solana-labs/solana/blame/89e5640c63a6683c2bd90fb963c837300ece9307/web3.js/src/connection.ts#L4239-L4241

Proposed Solution

Null-check the value, instead of falsey-checking it.

[steveluscher]

Interested in fixing this one up, @hareeshnagaraj?

[Mark-777-0]

I'm new to open source Could I fix this? Would you assign it to me? @steveluscher

[steveluscher]

Do it to it, @Mark-777-0!

[Mark-777-0]

On it!

[Mark-777-0]

I did a few tests with it and it seems to be working, it's just set up the same way as the statement below it. The PR just follows your proposed solution.

Let me know if I broke any etiquette. Very new to pull requests :). Not sure how to properly link it here