-
Notifications
You must be signed in to change notification settings - Fork 4.5k
web3.js Roadmap – November 2022 – Discussion thread #28783
Comments
Hi! Please let me know if this isn't the correct forum for this ask :). It seems like some important JSON RPC parameters are missing from the library. Most impactful off the top of my head would be the For example, I'm unable to do this: await connection.getBlock(164000050, {
maxSupportedTransactionVersion: 0,
transactionDetails: 'none'
}); Currently, the above code throws an error. Also, please let me know if I am simply in error and there actually is a way to do this :) |
Absolutely the right place! You've caught me fixing bugs this week, so I'll do this now, #28999. |
Wow thanks for the quick response! While you're working on this, it might be worthwhile adding other optional params for export type GetVersionedBlockConfig = {
/** The level of finality desired */
commitment?: Finality;
/** The max transaction version to return in responses. If the requested transaction is a higher version, an error will be returned */
maxSupportedTransactionVersion?: number;
}; It's missing a few options from the JSON-RPC endpoint: https://docs.solana.com/developing/clients/jsonrpc-api#getblock. Of course, the additional asks don't need to be in the same fix/issue, but wanted to give a heads up :) |
Yeah. I'm on it. The whole thing is a bigger mess than I could have imagined. |
Thanks! It makes sense there are some additional considerations. After I posted this request, I tried to @ts-ignore and force the request through, but ran into various deserialization errors. Looking forward to this PR getting merged in, I'll be able to use it immediately 👍 |
Alright, on to December! https://github.com/solana-labs/solana/milestone/203 |
What do you want to see accomplished in
@solana/web3.js
in the month of November 2022?Milestone: https://github.com/solana-labs/solana/milestone/202
The text was updated successfully, but these errors were encountered: