Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust BPF: Add support for float and signed division #3102

Closed
jackcmay opened this issue Mar 4, 2019 · 3 comments · Fixed by #18084
Closed

Rust BPF: Add support for float and signed division #3102

jackcmay opened this issue Mar 4, 2019 · 3 comments · Fixed by #18084
Assignees
Labels
bug Something isn't working locked issue
Milestone

Comments

@jackcmay
Copy link
Contributor

jackcmay commented Mar 4, 2019

Problem

The BPF instruction set does not contain a signed-division instruction and Rust's use of floats includes code that attempts to generate one. Either the Rust code needs to be rewritten, the LLVM back-end needs to compensate and lower those operations to something compatible, or BPF must add a new instruction to support it. Currently, floats are mostly disabled in the core libraries.

Proposed Solution

@stale
Copy link

stale bot commented Apr 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Apr 20, 2021
@dmakarov dmakarov self-assigned this Apr 20, 2021
@stale stale bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label Apr 20, 2021
@dmakarov dmakarov added the bug Something isn't working label Jun 9, 2021
@dmakarov
Copy link
Contributor

dmakarov commented Jun 9, 2021

This is related to #17793.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

This issue has been automatically locked since there has not been any activity in past 7 days after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working locked issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants