Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable downstream builds for spl and openbook-dex #32378

Closed
1 of 2 tasks
KirillLykov opened this issue Jul 5, 2023 · 3 comments
Closed
1 of 2 tasks

Re-enable downstream builds for spl and openbook-dex #32378

KirillLykov opened this issue Jul 5, 2023 · 3 comments
Assignees
Labels
stale [bot only] Added to stale content; results in auto-close after a week.

Comments

@KirillLykov
Copy link
Contributor

KirillLykov commented Jul 5, 2023

Problem

We disabled downstream project builds in this commit

Why: due to upgrade of borsh from 0.9.3 to 0.10.3

Proposed Solution

To re-enable them "we'll have to add a fix to maintain borsh's transitive dependency on hashbrown to 0.12.3, since cargo will automatically upgrade it during the downstream build, causing the program builds to fail." (#30975 (comment))

@KirillLykov
Copy link
Contributor Author

One way to resolve spl problem is to add getrandom dependency: solana-labs/solana-program-library#4703

@KirillLykov
Copy link
Contributor Author

Looks like spl build has been disabled again. But now I believe it can be re-enabled.
My understanding is that these scripts we used before for buildkite are deprecated because we migrated to gitactions

Regarding re-enabling openbook, we need to add openbook-dex-v2 which is a new version written from scratch. I will take it but I might need some guidance from @yihau regarding these gitactions

@yihau
Copy link
Member

yihau commented Aug 16, 2023

sure. in #32677, I added some new files

  1. .github/scripts/purge-ubuntu-runner.sh => a tool to get more space on a runner. if you don't use all default space, you don't need it.
  2. .github/scripts/downstream-project-spl-common.sh => I extracted logic from old scripts. you can do similar thing to openbook-dex or just write it in an action
  3. .github/workflows/downstream-project-spl.yml => the main script we need. I added workflow_call to have it reusable
  4. .github/workflows/downstream-project-spl-nightly.yml => basically run .github/workflows/downstream-project-spl.yml but triggering by the cron mechanism.

@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Aug 16, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Development

No branches or pull requests

2 participants