Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOMAXPROCS discarded by upstart init due to sudo's env_reset option #126

Closed
bdellegrazie opened this issue May 27, 2015 · 2 comments · Fixed by #130
Closed

GOMAXPROCS discarded by upstart init due to sudo's env_reset option #126

bdellegrazie opened this issue May 27, 2015 · 2 comments · Fixed by #130

Comments

@bdellegrazie
Copy link
Contributor

Hi,

In upstart init version GOMAXPROCS is set correctly but then the actual consul-agent process is started via sudo.
In Ubuntu the default sudo configuration has env_reset configured and GOMAXPROCS is not part of the env_keep configuration.
I'd suggest adding a default for the consul user which has GOMAXPROCS as part of env_keep configuration to avoid it being ignored.

@bdellegrazie
Copy link
Contributor Author

Another alternative is to drop the requirement for using sudo and instead use either /bin/su or setuid and setgid for later versions of upstart.

@solarkennedy
Copy link
Contributor

Arg. I would be down for an alternative to sudo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants