Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging missing dependency on Package['unzip'] #164

Closed
jhance opened this issue Aug 9, 2015 · 4 comments · Fixed by #166
Closed

Staging missing dependency on Package['unzip'] #164

jhance opened this issue Aug 9, 2015 · 4 comments · Fixed by #166

Comments

@jhance
Copy link

jhance commented Aug 9, 2015

For obvious reasons this package is needed. It doesn't seem like staging itself manages this (since it doesn't manage the unzip package), so consul should manage this dependency if it is managing the unzip package (ie, on non-darwin).

It should be sufficient (probably better) only to supply this to the files that consul itself downloads. For myself I am currently using Package['unzip'] -> Staging::File <| |> as a workaround.

@solarkennedy
Copy link
Contributor

On install.pp:19 we do this, so I think we are covered. Or are you asking for the package unzip to be chain ordered before we try to unzip the file?

@aj-jester
Copy link

Or are you asking for the package unzip to be chain ordered before we try to unzip the file?

I think thats what he means. Should be a simple fix, I can work on this sometime today.

@jhance
Copy link
Author

jhance commented Aug 10, 2015

I think thats what he means. Should be a simple fix, I can work on this sometime today.

Yes, thats what I mean. And yeah, this is pretty simple. Otherwise the ordering puppet is doing is trying to unzip the file, then install the unzip package, which doesn't work.

@aj-jester
Copy link

PR #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants