Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for puppet-archive >=1.0.0 #275

Closed
mgla opened this issue Aug 25, 2016 · 7 comments
Closed

Support for puppet-archive >=1.0.0 #275

mgla opened this issue Aug 25, 2016 · 7 comments

Comments

@mgla
Copy link

mgla commented Aug 25, 2016

The current version of puppet-archive is v1.1.1, and it seems to work just fine with v.1.1.1 (I am not able to verify this). Maybe update the metadata.json to allow newer archive versions without error?

Current dependency:

    {
      "name": "puppet/archive",
      "version_requirement": ">=0.5.0 <1.0.0"
    }
@epleterte
Copy link

I hit this now as well. From puppet-librarian:

[Librarian] Conflict between puppet-archive (< 1.0.0, >= 0.5.0) <(no source specified)> and puppet-archive/1.0.0 <https://forgeapi.puppetlabs.com>
Could not resolve the dependencies.

I will try just allowing a newer version of the archive module.

@ghoneycutt
Copy link
Member

Tried using puppet/archive v1.1.1 and it has syntax errors that made it unusable at all with Puppet v3.

@mgla
Copy link
Author

mgla commented Aug 28, 2016

@ghoneycutt Can you elaborate on the syntax errors? It works fine for me

@solarkennedy
Copy link
Contributor

The only build failures in #227 are related to Puppet 3.1.0.
I'm pretty sure we have test coverage to cover all the cases where we use archive.

@KZachariassen
Copy link
Contributor

Can we get this fixed soon? unable to install on Ubuntu 16.04 without this fix.

@solarkennedy
Copy link
Contributor

@ghoneycutt can you look at #277? I did have to remove 3.1.0 from the matrix, the exact failure was here: https://travis-ci.org/solarkennedy/puppet-consul/jobs/155769754

The matrix on that pr still has 3.3, 3.7, and 3.8, so decent v3 coverage?

@solarkennedy
Copy link
Contributor

I've release 1.1.0 of this module with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants