Send SIGHUP to consul agent when new checks/services are detected

[dannykansas]

Currently, when a new check or service is added, Consul does not load the check/service unless a "consul reload" is manually run on the node (or SIGHUP sent to the agent process).

Could we start a discussion on the appropriate times to trigger a reload of configuration files (i.e. new check added)?

[solarkennedy]

What? It should be restarting the service after any config change:
https://github.com/solarkennedy/puppet-consul/blob/master/manifests/check.pp#L53
https://github.com/solarkennedy/puppet-consul/blob/master/manifests/service.pp#L60

[dannykansas]

Interesting. The only relevant output I'm seeing after configuration change is as follows (Debian 7.6 nodes):

Notice: /Stage[main]/Consul::Run_service/Service[consul]/ensure: ensure changed 'stopped' to 'running'
Info: /Stage[main]/Consul::Run_service/Service[consul]: Unscheduling refresh on Service[consul]

Actually, this info appears with each puppet run, regardless of whether configuration changed or not. Possibly my implementation is wrong?

[solarkennedy]

Yea, it sounds like puppet is continuously trying to start consul.

Is it:
A: Consul isn't actually starting at all? (bad config, etc).
Try to start consul yourself and check logs.
or
B: Puppet isn't detecting that consul is already running?
Confirm with a ps that consul is running before puppet runs.
Pastebin a puppet run with --debug and a full ps -ef

[solarkennedy]

@dannykansas can you confirm if this is still an issue? Is consul even running like normal?

[dominikschulz]

In https://github.com/solarkennedy/puppet-consul/blob/master/manifests/service.pp#L90 there is a Notify on Class[consul::run_service]. Shouldn`t that rather be a Notify on Service[consul]?

[solarkennedy]

Notifying the entire class is ok, it should in-turn notify any resources inside, including Service[consul]

[aj-jester]

Fixed #152