Update README, ensure passingonly is a bool #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentation Add top-level namespaces everything (prefix ::) for future compatibility. Differentiate agent and server configs, provide examples for both. Update consul::service code example to match some recent manifest changes to that file. Alphabetize parameters. Change 'true' to '/bin/true' to prevent confusion about what 'true' means in that context. Delete trailing whitespace Closes #110
|
ack! a failure! I'll fix it tomorrow. Looks like the test is expecting a quoted string, too! |
|
Thanks! Super great. |
solarkennedy
added a commit
that referenced
this pull request
Apr 22, 2015
Update README, ensure passingonly is a bool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two commits:
First-
Add top-level namespaces for everything (prefix ::) for future compatibility.
Differentiate agent and server configs, provide examples for both.
Update consul::service code example to match some recent manifest changes to that file.
Alphabetize parameters.
Change 'true' to '/bin/true' to prevent confusion about what 'true' means in that context.
Delete trailing whitespace
Closes #110, #97
I tested all of the code in the README except
consul_acl, I couldn't get it to work on my system.. kept timing out. The Puppet/Ruby code was fine, as far as I could tell, but I couldn't ensure it did what it was supposed to.Second-
Ensure passingonly is a bool
Closes #97