Supply optional token for ACL changes #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,14 +16,14 @@ def self.list_resources | |||
| uri = URI('http://localhost:8500/v1/acl') | |||
| http = Net::HTTP.new(uri.host, uri.port) | |||
|
|
|||
| path=uri.request_uri + '/list' | |||
| path=uri.request_uri + "/list?token=#{acl_api_token}" | |||
There was a problem hiding this comment.
Does this work when the token is set to an empty string? Like consul tolerate a /list?token= ?
There was a problem hiding this comment.
Yes, that's assumed to be the anonymous token.
|
I am also not an expert on this part of the code (custom providers), but I understand that often the ACLs will not be setup in such a way for puppet to prefetch them. I don't currently use this ACL code at all, but I would like to. Thank you for your help in getting this ACL code in a more production-ready state! |
solarkennedy
added a commit
that referenced
this pull request
Jun 2, 2015
Supply optional token for ACL changes
|
this commit seems to break "ensure" capability of creating ACL resources. |
|
Crap :( @activars can you pastebin with output? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems likely that the Consul cluster will not allow the anonymous token to make ACL changes, so it would be nice if you could supply a token with the right privileges. I tried setting that up in this PR. I had to delete the prefetch methods, since they wouldn't have access to the token. However maybe there is a better way to handle it.