Added custom init style "custom" #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for scenarios when you want to start consul from another program manager, e.g supervisor (supervisord.org).
Full example:
class { 'consul':
package_ensure => $package_ensure,
config_hash => $config_hash,
init_style => 'custom',
}
supervisor::program { 'consul':
command => '/usr/local/bin/consul agent -config-dir /usr/local/consul/conf',
user => 'consul',
group => 'consul',
}
| @@ -78,6 +78,9 @@ | |||
| content => template('consul/consul.launchd.erb') | |||
| } | |||
| } | |||
| 'custom' : { | |||
| notice("I'm not creating an init script for you as you are going to create one yourself") | |||
There was a problem hiding this comment.
No notice please. This causes puppet to never converge.
|
Can't people already do this if they say |
This is useful for scenarios when you want to start consul from another program manager, e.g supervisor (supervisord.org) and don't want consul::config generated init file but still require a reload mechanism.
|
solarkennedy
added a commit
that referenced
this pull request
Feb 29, 2016
Added custom init style "custom"
|
Gotcha. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for scenarios when you want to start consul from another program manager, e.g supervisor (supervisord.org).
Full example:
class { 'consul':
package_ensure => $package_ensure,
config_hash => $config_hash,
init_style => 'custom',
}
supervisor::program { 'consul':
command => '/usr/local/bin/consul agent -config-dir /usr/local/consul/conf',
user => 'consul',
group => 'consul',
}
This change will prevent puppet-consul from creating an init script and managing the process, so the supervisor could do this instead.